Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement to enter email address on unsubscribe #21175

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Aug 18, 2021

Overview

I find it very annoying when I have to do additional work to actually unsubscribe from a mailing list - especially when doing so via a device without a keyboard! Most list unsubscribe forms don't require you to enter any details these days and usually just ask you to confirm.

Following discussion this PR is now updated to remove the requirement to enter email address instead of adding a setting

You are not asked to re-enter your email address on unsubscribe.

Before

You must enter your email address correctly in the text box:
image

After

You just need to read the form and click "Unsubscribe":
image

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 18, 2021

(Standard links)

@civibot civibot bot added the master label Aug 18, 2021
@mattwire mattwire force-pushed the unsubscribeverifyemail branch from d63c97b to e07b826 Compare August 18, 2021 18:51
@seamuslee001
Copy link
Contributor

This makes sense to me but maybe we need to just circulate in the dev digest first @eileenmcnaughton. Concept seems fine to me but it does hypothetically risk increase of accidental unsubscribe but that is probably a small risk

@mattwire
Copy link
Contributor Author

@seamuslee001 @eileenmcnaughton Agree with putting this to dev-digest first. I've been getting more and more annoyed with sites that seem to make it "difficult" to unsubscribe and then I realised that CiviCRM is one of them so decided I'd better fix!

@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Aug 18, 2021

I've added a note to include this in the dev-digest. I see adding a test as a pretty important requirement for adding a new setting so it might be worth you confirming you are happy to write one before I write it up for the digest @mattwire

@mlutfy
Copy link
Member

mlutfy commented Aug 19, 2021

Personally I would just remove the old behaviour completely.

@mattwire
Copy link
Contributor Author

Personally I would just remove the old behaviour completely.

@mlutfy I'd do the same but wasn't sure if that would be acceptable!

@highfalutin
Copy link
Contributor

I'm all for this.

@mlutfy
Copy link
Member

mlutfy commented Aug 30, 2021

@colemanw You had indicated a thumbs-up on the initial PR. Would you be comfortable with removing the behaviour completely?

ping @agh1 @artfulrobot @MegaphoneJon (pinging folks with more complex mailing experience)

@agh1
Copy link
Contributor

agh1 commented Aug 30, 2021

Pinging @KarinG because I remember her building this feature in the first place. I looked back and found that this feature was introduced in CRM-11302 so you can see a little bit of discussion there.

Personally, I agree it's annoying to type in your address and would be happy to be rid of it.

I also wonder: what's the concern about displaying the full email address on the form? I can imagine someone might forward their email to a friend, who then forwards to another friend. It's likely that the forwards have the original recipient's email on it already. If not, the email address isn't particularly sensitive information, and this friend-of-a-friend could probably do a lot more damage by clicking the unsubscribe button than by knowing the email address.

Finally, opt out is a separate form and anything that changes on the unsubscribe form should change over there, too.

@MegaphoneJon
Copy link
Contributor

I'm a +1 for removing this altogether. I checked CRM-11302 and IMO we'd be satisfying the original intent without requiring you type the email.

@KarinG
Copy link
Contributor

KarinG commented Aug 30, 2021

Hi! Back then I had no opinion on anything :-) I only implemented the masking/verification input because Dave Greenberg told me to do it! Happy to see it go if people feel that's better.

@eileenmcnaughton
Copy link
Contributor

I don't have an opinion on this - but I think it has good engagement from all the people who I think should be engaged - so I'm happy with whatever you agree

@agileware-justin
Copy link
Contributor

Would be really happy if the feature was completely removed. No need for a setting.

@eileenmcnaughton
Copy link
Contributor

@mlutfy I'm going to unsubscribe on this & leave it to you to decide what is agreed :-)

@artfulrobot
Copy link
Contributor

+1 for removing having to enter your email, it's a PITA and is likely to annoy people who have already decided they don't like you, which can't be good manners.

I don't think we should display the email address verbatim. Just a feeling.

Not that this has been suggested, but: we definitely still need the button press to confirm the unsubscribe (to avoid link scanners unsubscribing people).

@mlutfy
Copy link
Member

mlutfy commented Aug 31, 2021

Thanks for the feedback everyone. It's one of those small changes to UX, that I suspected folks might have strong feelings about, and I wanted to make sure we don't break any workflows by doing this change (even if adding the setting is technically "safer", it's more work, more code, and I doubt anyone would use it).

To summarize discussion & my opinion:

  • no need for a setting, remove the email verification completely
  • still display the email address, but keep it masked (m*@example.org). I think it's still useful info to display (for folks with multiple emails), and while it's a bit odd to mask it, I don't think it does much harm. Also keep the button that needs to be clicked to complete the operation.
  • adopt the same behaviour on the opt-out form.

Besides the code removal, the 3rd point above would require a bit more work.

@mattwire What do you think? Could you update your PR?

@mattwire
Copy link
Contributor Author

@mlutfy That's great and was also my preferred solution. I will update the PR in the next day or so.

@agileware-justin
Copy link
Contributor

Awesome thanks @mattwire

Do we really need to mask the email address? Either show it entirely or don't, masking it is nothing more than "security theatre". It's more confusing than useful.

My preference is not to show the email address at all.

@artfulrobot
Copy link
Contributor

artfulrobot commented Sep 1, 2021

nothing more than "security theatre".

I disagree. As someone who has multiple email addresses, it's very useful to me to see which is affected by an unsubscribe.

As for displaying the whole thing, I suppose it's just the uneducated user this protects. e.g. Fred receives an email and likes it. They click the web view and share that link on social media. Everyone on social media now has their email and Fred might not even notice/know.

@agileware-justin
Copy link
Contributor

@artfulrobot if our job is to now try and protect what people share on social media, then I'm definitely tapping out! 😄

@mlutfy
Copy link
Member

mlutfy commented Sep 1, 2021

I'd rather keep the email masking as a separate issue. I don't think we will get an easy consensus on that one.

@mattwire mattwire force-pushed the unsubscribeverifyemail branch from e07b826 to 8da8055 Compare September 2, 2021 10:54
@mattwire mattwire changed the title Add setting to disable email verification on unsubscribe Remove requirement to enter email address on unsubscribe Sep 2, 2021
@mattwire mattwire force-pushed the unsubscribeverifyemail branch from 8da8055 to cebe368 Compare September 2, 2021 11:00
@mattwire
Copy link
Contributor Author

mattwire commented Sep 2, 2021

@mlutfy PR now updated to remove the requirement for email verification altogether. Now you just have to read and click.

Note that I ended up cleaning up the form code a bit so it looks like a bigger change than it actually is!

@mattwire
Copy link
Contributor Author

mattwire commented Sep 2, 2021

Also please see #21350 for opt-out form.

@mattwire mattwire force-pushed the unsubscribeverifyemail branch from cebe368 to ec436db Compare September 6, 2021 15:12
@wmortada
Copy link
Contributor

wmortada commented Sep 6, 2021

+1 for removing the requirement to confirm your email address.

I imagine that this was put in place to prevent people from inadvertently unsubscribing someone else if the original subscriber had forwarded the mailing to them. However, as others have said it's a poor user experience. Displaying the partial email address should be enough to prevent this from happening.

@mlutfy mlutfy merged commit 0a3cf17 into civicrm:master Sep 6, 2021
@mlutfy
Copy link
Member

mlutfy commented Sep 6, 2021

I did some tests and the requirement is indeed gone. Thank you @mattwire & reviewers!

@mlutfy
Copy link
Member

mlutfy commented Sep 6, 2021

For more discussion on the topic, see:
https://lab.civicrm.org/dev/user-interface/-/issues/42

@artfulrobot
Copy link
Contributor

Thanks everyone! This is a good ux improvement.

@mattwire mattwire deleted the unsubscribeverifyemail branch September 7, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.