Move financial acl setting to the extension #21120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| $this->callAPISuccess('Setting', 'create', [ | ||
| 'contribution_invoice_settings' => array_merge($contributeSettings, ['acl_financial_type' => TRUE]), |
There was a problem hiding this comment.
this was actually the first setting we separated out of the contribution_invoice_settings borg & has been a free agent even longer than the rest
eileenmcnaughton
force-pushed
the
acl_setting
branch
from
d56102d to
a572646
Compare
|
@seamuslee001 I think this should be an easy merge = it's a move + some test fixes around caching |
|
Jenkins re test this please |
|
I agree with this, just getting Jenkins to re-run given its been a bit of time since it was last run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move financial acl setting to the extension
Before
Setting in main settings
After
Setting in the extension
Technical Details
The onChange is mostly to support unit tests
Comments