dev/core#2743 fix api v3 to not unnecessarily load options

[eileenmcnaughton]

Overview

dev/core#2743 fix api v3 to not unnecessarily load options

Before

Campaign options loaded for verification even when its already an int

After

Only loaded if needed

Technical Details

We don't need to validate if already numeric

Comments

@colemanw this is actually very similar to @pfigel's hack & I think it makes sense for the rc

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I have re-written this line 8 times so I'm gonna write out what I'm doing

We will validate if it's a a pseudoconstant, has options or is campaign id

AND it is not an FK OR the value is not numeric

Ie if it is an FK & we have a string then validate
if it's numeric & it's controlled by option values then validate

but don't validate a numeric FK field

[colemanw]

This looks good code-wise and makes a lot of sense. It's also heavily covered by tests.

[eileenmcnaughton]

@colemanw this caused 3 test failures - in all 3 cases they were upset about the subtle difference in the error message. I kept one test but removed the error message check & I actually removed the other 2. In general I think we have an overkill of these tests that check failure messages so keeping 1 was enough IMHO