Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Expand test coverage for scheduled-reminders with {activity.*} tokens #21092

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

totten
Copy link
Member

@totten totten commented Aug 11, 2021

Overview

Expand test coverage for actionschedules with {activity.*} tokens.

This is extracted from @mattwire's branch in #16983.

Before

Less tests

After

More tests

Technical Details

Programming

@civibot
Copy link

civibot bot commented Aug 11, 2021

(Standard links)

@civibot civibot bot added the master label Aug 11, 2021
@totten totten changed the title (NFC) Expand test coverage for actionschedules with {activity.*} tokens (NFC) Expand test coverage for scheduled-reminders with {activity.*} tokens Aug 11, 2021
@eileenmcnaughton
Copy link
Contributor

@totten does this test anything that is changed in any pr? (I mean it's generally good to test cover - just looking to understand if it adds tests to anything open pr related)

@totten
Copy link
Member Author

totten commented Aug 11, 2021

@eileenmcnaughton In its original context, I believe the idea was: "This PR is changing the activity-tokens, so we should have more coverage for activity-tokens. Test-first/refactor-second". So, eg, one might have more confidence in a PR like #21088 with extra coverage.

@totten totten merged commit a281e78 into civicrm:master Aug 11, 2021
@eileenmcnaughton
Copy link
Contributor

Ok cool - it's probably a good starting point from which to make activity token coverage extensive

@totten totten deleted the master-acttok-test branch August 11, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants