Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check to see if the financialAclExtension is installed #21077

Merged

Conversation

johntwyman
Copy link
Contributor

Overview

This PR fixes a small mistake in the incremental upgrader.

Before

The reference to the key/value pair that determines if an extension is installed is incorrect: $financialAclExtension['status'].

After

The reference is fixed: $financialAclExtension['values'][0]['status'].

Comments

I don't know how to test this to be honest but I have used the API3 Explorer to confirm the data model for results return from civicrm_api3('extension', 'get', ...) calls is such that the status key definitely sits within the array underneath the values key. It is not at the same level of the object as the count key.

@civibot
Copy link

civibot bot commented Aug 10, 2021

(Standard links)

@civibot civibot bot added the master label Aug 10, 2021
@eileenmcnaughton eileenmcnaughton merged commit 1198660 into civicrm:master Aug 10, 2021
@johntwyman johntwyman deleted the fix-setPreUpgradeMessage-function branch August 10, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants