Fix the check to see if the financialAclExtension is installed #21077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a small mistake in the incremental upgrader.
Before
The reference to the key/value pair that determines if an extension is installed is incorrect:
$financialAclExtension['status']
.After
The reference is fixed:
$financialAclExtension['values'][0]['status']
.Comments
I don't know how to test this to be honest but I have used the API3 Explorer to confirm the data model for results return from
civicrm_api3('extension', 'get', ...)
calls is such that thestatus
key definitely sits within the array underneath thevalues
key. It is not at the same level of the object as thecount
key.