Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enotice fix #21041

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Enotice fix #21041

merged 1 commit into from
Aug 6, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Enotice fix

Before

image

image

After

image

Technical Details

This one is a bit of a brain twister but I'm pretty sure the re-ordered IF has the
same result - but one less enotice

Comments

This one is a bit of a brain twister but I'm pretty sure the re-ordered IF has the
same result - but one less enotice
@civibot
Copy link

civibot bot commented Aug 6, 2021

(Standard links)

@civibot civibot bot added the master label Aug 6, 2021
@demeritcowboy
Copy link
Contributor

So many s's. I'll give this one a shot.

@demeritcowboy
Copy link
Contributor

BEFORE

  savedSearch not savedSearch
ssid and rows Edit SGC Edit SC
ssid and not rows Edit SGC Edit SC
not ssid and rows Edit SGC Edit SC
not ssid and not rows Edit SGC SC

AFTER

  savedSearch not savedSearch
ssid and rows Edit SGC Edit SC
ssid and not rows Edit SGC Edit SC
not ssid and rows Edit SGC Edit SC
not ssid and not rows Edit SGC SC

Comments

Did a little r-run. Looks good.

@demeritcowboy demeritcowboy merged commit 52c0a79 into civicrm:master Aug 6, 2021
@eileenmcnaughton eileenmcnaughton deleted the notice2 branch August 6, 2021 14:54
@eileenmcnaughton
Copy link
Contributor Author

How can 13 lines of code be so painful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants