Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] Fix CRM.url to not encode hash on WP #21020

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 5, 2021

Overview

Fixes a regression where the link to edit a SavedSearch from Afform is broken on WP.

Before

This link doesn't work on WP, due to a url encoding issue in CRM.url():

image

After

Fixed.

Technical Details

This regressed in 7cf0b33

@civibot
Copy link

civibot bot commented Aug 5, 2021

(Standard links)

@civibot civibot bot added the master label Aug 5, 2021
@seamuslee001
Copy link
Contributor

@colemanw should this be against the 5.40 branch?

@eileenmcnaughton
Copy link
Contributor

@colemanw shouldn't this be against the rc?

@colemanw colemanw changed the base branch from master to 5.40 August 5, 2021 03:10
@civibot civibot bot added 5.40 and removed master labels Aug 5, 2021
@colemanw
Copy link
Member Author

colemanw commented Aug 5, 2021

Changed

@totten
Copy link
Member

totten commented Aug 5, 2021

Code looks sensible. Tested (r-run) in WP+5.39 and D7+5.40, and URL fragments are generated reasonably.

Merge on pass.

@eileenmcnaughton eileenmcnaughton merged commit aa66e25 into civicrm:5.40 Aug 5, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixWPUrlHash branch August 5, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants