Temporary revert of changes in 20002 which caused a regression #21016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This backs out the changes in #20002 to allow us to fix the regression in long standing functionality. The goal is to re-ininstate the functionality but given we have 2 pieces of functionality currently in conflict with one being from 5.38 & the other being long-standing this seems the more stable approach
Before
#20997 scenario broken. new functionality in #20002 works
After
The reverse - for better and worse. However, the long-standing functionality is now locked in with a test
Technical Details
Note that there is fairly long discussion on #20997 & quite a bit of complexity
Comments