Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary revert of changes in 20002 which caused a regression #21016

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 4, 2021

Overview

This backs out the changes in #20002 to allow us to fix the regression in long standing functionality. The goal is to re-ininstate the functionality but given we have 2 pieces of functionality currently in conflict with one being from 5.38 & the other being long-standing this seems the more stable approach

Before

#20997 scenario broken. new functionality in #20002 works

After

The reverse - for better and worse. However, the long-standing functionality is now locked in with a test

Technical Details

Note that there is fairly long discussion on #20997 & quite a bit of complexity

Comments

@civibot civibot bot added the 5.40 label Aug 4, 2021
@civibot
Copy link

civibot bot commented Aug 4, 2021

(Standard links)

@eileenmcnaughton eileenmcnaughton changed the title Jamie Temporary revert of changes in 20002 which caused a regression Aug 4, 2021
@demeritcowboy
Copy link
Contributor

Did some basic r-run - looks ok.

@seamuslee001 seamuslee001 merged commit e59d0da into civicrm:5.40 Aug 5, 2021
@seamuslee001 seamuslee001 deleted the jamie branch August 5, 2021 01:41
@totten totten mentioned this pull request Aug 5, 2021
eileenmcnaughton added a commit that referenced this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants