Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - fix deprecated join #20968

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

colemanw
Copy link
Member

Overview

Fixes deprecated warning noted in https://lab.civicrm.org/dev/core/-/issues/2689#note_62477

Replaces #20966

Fixes dev/core#2689
@civibot
Copy link

civibot bot commented Jul 28, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

Ah cool. Thanks.
Works.

@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Jul 28, 2021

wrong pr

@demeritcowboy
Copy link
Contributor

jenkins retest this please

CRM_Core_Payment_AuthorizeNetIPNTest::testIPNPaymentRecurNoReceipt
GuzzleHttp\Exception\ConnectException: cURL error 7: Failed to connect to apitest.authorize.net port 443: Connection timed out (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

@demeritcowboy
Copy link
Contributor

Oh, I see that test is failing everywhere.

@eileenmcnaughton
Copy link
Contributor

yeah - we can ignore that one - I think we do a live curl call to A.net (they must love us)

@eileenmcnaughton eileenmcnaughton merged commit 0b78d02 into civicrm:master Jul 28, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixDeprecatedJoin branch July 28, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants