dev/core#2721 [Ref] simplify passed parameters #20955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 3 types of saved searches - search kit - legacy core searches - legacy custom searches The only information these 3 need to load is the savedSearch details and the group ID (to add in the add & exclude). The wrangling of the params should happen in the getSql functions - which we can think about being in a listener once they have standard inputs & outputs. However, to get to that point we want to standardise those inputs & outputs. This removes only point of randomness - ie savedSearch has a consistent value & the wrangling of what is in it is pushed closer to the relevant functions
|
(Standard links)
|
I think if we want to make this some sort of hook or listener we don't really want to pass out 'add select' and 'exclude clause' when they are just group id with a bit of string. It seems cleaner to specify the sql within the function
eileenmcnaughton
changed the title
|
This works for me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Ref] simplify passed parameters
Builds on #20954 but narrows the functions down to receive groupID and savedSearch as an array
Before
sql being partly constructed in the calling function but given to the sql functions to compile
After
It's done in the sql functions
Technical Details
Even though this is arguably repetitive I think it makes more sense once we start thinking about offering some
some sort of hook or listener - ie it seems cleaner to specify the sql within the function than to pass some in
Comments