Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Better handling of output value using GROUP_CONCAT #20896

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

colemanw
Copy link
Member

Overview

Followup to #20655 to improve output formatting of the GROUP_CONCAT sql function in APIv4

Before

Output formatting disabled if function nested within function

After

Output formatting controlled by the inner function

@civibot
Copy link

civibot bot commented Jul 18, 2021

(Standard links)

@civibot civibot bot added the master label Jul 18, 2021
@colemanw
Copy link
Member Author

colemanw commented Jul 18, 2021

Ping @seamuslee001 can you test this with php8?

@seamuslee001
Copy link
Contributor

I ran the apiv4 unit tests on php8 with this patched and it works merging

@seamuslee001 seamuslee001 merged commit 38a3cab into civicrm:master Jul 18, 2021
@seamuslee001 seamuslee001 deleted the groupConcatOutputValue branch July 18, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants