dev/core#2719 [REF] Remove some legacy references to contribution_invoice_settings

[eileenmcnaughton]

Overview

[REF] Remove some legacy references to contribution_invoice_settings

Before

  $invoiceSettings = Civi::settings()->get('contribution_invoice_settings');
  $invoicing = $invoiceSettings['invoicing'];

After

$invoicing = Civi::settings()->get('invoicing')

Technical Details

These subkeys are now settings in their own right & can be accessed directly. The Settings code handles
inconsistencies so we don't need to

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[yashodha]

test failures don't look related. Test this please.

[eileenmcnaughton]

@yashodha are you OK merging this?

[mlutfy]

@eileenmcnaughton If extensions were checking this setting previously, will they break? (I don't really worry about it, but will document more clearly for release blog)

[eileenmcnaughton]

@mlutfy no - there is actually code in the settings bag that handles it quietly - it would be nice to deprecate calling it indirectly - which I could do as a follow up

[mlutfy]

Sounds good, thanks :)