dev/core#2716 [REF] Stop 'distributing' the main flow

[eileenmcnaughton]

Overview

[REF] Stop 'distributing' the main flow

The main flow in this function is when the transaction type is subscr_payment -
handling for this is 'distributed' into 3 different parts of the function - this
consolidates it. There is some 'expense' of doing the recur save 'when it happens'
in terms of lines of code but it is still less loopy

Before

Handling for the main flow 'distributed' between the initial check, the switch statement and 'after the return'

After

Consolidated into 'after the return'

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).