Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-true-if #20853

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Remove never-true-if #20853

merged 1 commit into from
Jul 17, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 15, 2021

This code is in the recur() function. the lines immediately before this function is called (it is only called from one place) ensure contribution->contribution_status_id
is unset if it is 1 - meaning this if can never be true

This code is in the recur() function. the lines immediately before this function ensure contribution->contribution_status_id
is unset if it is 1 - meaning this if can never be true
@civibot
Copy link

civibot bot commented Jul 15, 2021

(Standard links)

@civibot civibot bot added the master label Jul 15, 2021
@colemanw
Copy link
Member

I'm looking but not seeing. Where is it unsetting contribution_status_id if 1?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw - it instantiates a new Contribution object without it

image

@colemanw
Copy link
Member

I see. I also note that it's an error condition that's not supposed to happen anyway.

@colemanw colemanw merged commit c38952e into civicrm:master Jul 17, 2021
@colemanw colemanw deleted the auth branch July 17, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants