Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #20848

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Remove deprecated code #20848

merged 1 commit into from
Jul 17, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 14, 2021

Overview

We deprecated NOT passing an id into the function in 2018 - this removes

Note I double checked - if you pass in '2' to a strict casting of int
it accepts it and casts to int

Before

image

After

poof

Technical Details

Comments

We deprecated NOT passing an id into the function in 2018 - this removes

Note I double checked - if you pass in '2' to a strict casting of int
it accepts it and casts to int
@civibot
Copy link

civibot bot commented Jul 14, 2021

(Standard links)

@civibot civibot bot added the master label Jul 14, 2021
@colemanw colemanw merged commit 0d919f7 into civicrm:master Jul 17, 2021
@colemanw colemanw deleted the dep branch July 17, 2021 01:41
@colemanw
Copy link
Member

I think 3 years is long enough to deprecate something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants