CustomGroup - change admin permission to 'administer CiviCRM data' #20833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permission is a subset of 'administer CiviCRM' and is more precise, allowing finer-grained admin permissions.
|
(Standard links)
|
colemanw
commented
Jul 12, 2021
| @@ -211,8 +211,6 @@ public static function group($groupType, $excludeHidden = TRUE) { | |||
| * @return bool | |||
| */ | |||
| public static function customGroupAdmin() { | |||
| $admin = FALSE; | |||
|
@eileenmcnaughton does this look like a good use of the new sub permissions? |
|
+1 from me |
|
The way the function is used is pretty weird - but the permission change to the lower permission is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fine-tunes the permissions needed to access all custom data.
Before
Users with
"administer CiviCRM"could access all custom data.After
Users with
"administer CiviCRM"can still access all custom data, but now users with'administer CiviCRM data'can do so as well.Technical Details
This permission is a subset of 'administer CiviCRM' and is more precise, allowing finer-grained admin permissions.