Enable check on created participant payment rows #20650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
partorder
branch
4 times, most recently
from
77e7085 to
e0b6b33
Compare
eileenmcnaughton
force-pushed
the
partorder
branch
from
a542c5f to
3e8e79b
Compare
This was referenced Jul 4, 2021
eileenmcnaughton
force-pushed
the
partorder
branch
2 times, most recently
from
67747ed to
b4bb296
Compare
Extend participant check
eileenmcnaughton
force-pushed
the
partorder
branch
from
b4bb296 to
95556e1
Compare
|
@monishdeb can you give this MOP now you've merged the other one - it is passing now & will lock in checking line items against participant payments |
|
Yep, reviewed the patch, looks good. |
|
Yay - it took a lot to get this passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extend test coverage to participant payment rows
Before
We are not checking contributions have consistency between participant line items and participant_payments
After
We ARE checking
Technical Details
This PR exposed a real bug - which is in a separate PR now #20670
This PR should be mergeable as is but I had intended to get that merged & then rebase it
Comments