Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the smarty variables for mem_status and mem_join_date for back-end membership renewals #20224

Merged
merged 1 commit into from
May 5, 2021

Conversation

agileware-justin
Copy link
Contributor

Overview

Set the smarty variables for mem_status and mem_join_date for back-end membership renewals.

Before

mem_status and mem_join_date are not available for back-end membership renewals. Which is problematic when trying to use the mem_status variable to display a "Thanks for renewing!" message or a "Welcome new member" when using the Memberships - Signup and Renewal Receipts (off-line) message template.

After

smarty variables for mem_status and mem_join_date are now available.

Technical Details

Comments

Agileware Ref: CIVICRM-1729

@civibot
Copy link

civibot bot commented May 5, 2021

(Standard links)

@civibot civibot bot added the master label May 5, 2021
@mattwire
Copy link
Contributor

mattwire commented May 5, 2021

We should be moving away from using smarty variables in favour of tokens in messagetemplates but we are a way off that yet (at least for memberships). These parameters should probably be locked in with a test but it's silly that some are passed in and others not.
I'm merging this because it makes it consistent with the more "standard" Contribution.sendconfirmation API and other contribution/membership workflows that send emails. Future cleanups will then be able to work with a consistent set of params.

@mattwire mattwire merged commit d88ce58 into civicrm:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants