Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Minor code cleanup #20175

Merged
merged 1 commit into from
Apr 28, 2021
Merged

[REF] Minor code cleanup #20175

merged 1 commit into from
Apr 28, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanups - use strict, declare exceptions, use use statement, do not use else if the if statement has already returned

Before

More margin chaos

After

less

Technical Details

Comments

@eileenmcnaughton
[REF] Minor code cleanup
20f4850 
Minor code cleanups - use strict, declare exceptions, use use statement
@civibot
Copy link

civibot bot commented Apr 28, 2021

(Standard links)

@civibot civibot bot added the master label Apr 28, 2021
@seamuslee001
Copy link
Contributor

Looks good to me merging

@seamuslee001 seamuslee001 merged commit 9bfb5ba into civicrm:master Apr 28, 2021
@seamuslee001 seamuslee001 deleted the nfc branch April 28, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001