dev/search#63 Add recurring contributions to contribution reports

[larssandergreen]

I've added Contribution Recurring as a filter, column and group by to the Contribution Summary report. After this has been reviewed, I'll add the same to other relevant reports. Thanks to @sluc23 for the dbAlias that I copied from his Report Plus extension.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

Not totally clear to me if I need the dbAlias in each of the three here, but testing seems to indicate yes.

[eileenmcnaughton]

Makes sense - @yashodha are you OK to review this?

[MegaphoneJon]

I'm not suggesting this isn't a worthwhile endeavor to do in core - but I want to point out that this already exists in Extended Reports, which has many improved versions of the core reports.

[larssandergreen]

@MegaphoneJon I didn't realise that this functionality exists in Extended Reports, because in order to filter for recurring or non-recurring payments you need to know that non-recurring payments have a null recurring payments field and recurring payments a non-null field. So hopefully this is a little simpler for folks like me who didn't know the database structure. But Extended Reports is great for flexibility and I think it's good to have this available in both.

[eileenmcnaughton]

I'm going to merge this - it seems fairly straight forward & obviously useful in some cases.