Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF Cleanup ReCAPTCHA code #20167

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

mattwire
Copy link
Contributor

Overview

This is a refactor in preparation for moving the reCAPTCHA code to the new reCAPTCHA extension for the campaign signature form.
See https://lab.civicrm.org/dev/core/-/issues/2571

Before

More complex, old code patterns.

After

Simpler, current code patterns.

Technical Details

This switches from using the $config object to retrieve settings via magic properties and uses the Civi::settings() functions.

Comments

@civibot
Copy link

civibot bot commented Apr 27, 2021

(Standard links)

@civibot civibot bot added the master label Apr 27, 2021
@eileenmcnaughton
Copy link
Contributor

@demeritcowboy this looks right to me - are all your concerns addressed?

@demeritcowboy
Copy link
Contributor

I hadn't run it but codewise looked good.

@eileenmcnaughton
Copy link
Contributor

I think this is simple enough / readable enough as a change that I'm going to merge without having r-run

@eileenmcnaughton eileenmcnaughton merged commit 86c9f98 into civicrm:master Apr 27, 2021
@mattwire mattwire deleted the recaptchaclean branch April 28, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants