REF reCAPTCHA Simplify buildCustom function on Registration form #20164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a refactor in preparation for moving the reCAPTCHA code to the new reCAPTCHA extension for the event registration pages.
See https://lab.civicrm.org/dev/core/-/issues/2571
Before
More complex code
After
Simpler code, will be easier to review next step which actually moves the code that adds the reCAPTCHA.
Technical Details
Split into 3 commits for ease of review.
CRM_Core_Session::getLoggedInContactID();
and moving the$button
to nearer the only place it is used.$viewOnly
parameter is never used in this function (looks like a copy/paste from other code that left it in place).Comments