Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Minor tidy up - use writeRecord #20159

Merged
merged 1 commit into from
Apr 27, 2021
Merged

[REF] Minor tidy up - use writeRecord #20159

merged 1 commit into from
Apr 27, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 27, 2021 •
edited
Loading

Overview

[REF] Minor tidy up - use writeRecord

Before

2 unused variables & an obsolete pass-by-ref (the passed in variables are not altered)

After

Switches to a preferred function call - writeRecord
Note that as a by-product hooks will now be called

Technical Details

Comments

@eileenmcnaughton
[REF] Minor tidy up - use writeRecord
85ddbcc 
This tidy up gets rid of 2 unused variables & an obsolete pass-by-ref and switches to a
preferred function call. Note that as a by-product hooks will now be called
@civibot
Copy link

civibot bot commented Apr 27, 2021

(Standard links)

@civibot civibot bot added the master label Apr 27, 2021
@seamuslee001
Copy link
Contributor

Looks fine to me MOP

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001 seamuslee001 merged commit 00c2cca into civicrm:master Apr 27, 2021
@seamuslee001 seamuslee001 deleted the actsh branch April 27, 2021 09:08
@colemanw
Copy link
Member

Good one @eileenmcnaughton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw