Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Exclude serialized fields from implicit join selection #20156

Conversation

colemanw
Copy link
Member

Overview

SearchKit automatically makes certain fields available, e.g. email contact -> display_name. This type of join is not possible with serialized values (e.g. a multi-valued ContactReference custom field).

See https://lab.civicrm.org/dev/core/-/issues/2553#note_58551

Before

"Display Name" shown as an option for multi-valued ContactReference custom fields, but didn't actually work.

After

Still doesn't work, but not shown as an option.

@civibot
Copy link

civibot bot commented Apr 27, 2021

(Standard links)

@civibot civibot bot added the master label Apr 27, 2021
@seamuslee001
Copy link
Contributor

This looks good to me

@seamuslee001
Copy link
Contributor

Merging so that this gets into the RC, the code looks right to me

@seamuslee001 seamuslee001 merged commit 98907ce into civicrm:master May 3, 2021
@seamuslee001 seamuslee001 deleted the searchKitExcludeSerializedFromAutoJoins branch May 3, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants