Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move more functions back to pdfLetter class #20155

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 27, 2021

Overview

[REF] Move more functions back to pdfLetter class

Before

Form processing 'spread' across 2 classes

After

Consolidated onto one

Technical Details

As with the previous moves this is

  1. covered by unit tests
  2. just code moving around

But note that this doesn't move whole functions but moves the
contents of postProcess & buildQuickForm back into the same functions
on the 'actual' class

Comments

@civibot
Copy link

civibot bot commented Apr 27, 2021

(Standard links)

@civibot civibot bot added the master label Apr 27, 2021
@eileenmcnaughton eileenmcnaughton changed the title [REF] Move more functions bask to pdfLetter class [REF] Move more functions back to pdfLetter class Apr 27, 2021
@colemanw
Copy link
Member

This looks like reasonable cleanup.

As with the previous moves this is
1) covered by unit tests
2) just code moving around

But note that this doesn't move whole functions but moves the
contents of postProcess & buildQuickForm back into the same functions
on the 'actual' class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants