Fix enotice when Log service is swapped out

[eileenmcnaughton]

Overview

Fix enotice when Log service is swapped out

Before

If the service retrieved by Civi::log() is NOT an instance of CRM_Core_Error_Log then there will be an enotice as there is no map property in the interface & there cannot be expected to be one in any alternate services

After

The array can be retrieved from a public function.

Technical Details

This function is calling a property on the psr_log service that may not exist. If the
service is swapped out there is no reason the replacement should have this property.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw can I get a merge on this - it fixes an issue from when you added logObserver (an obscure one)

[eileenmcnaughton]

@colemanw would be good to get this merged before we fork - it's arguably a regression of sorts

[colemanw]

I guess the alternative would be to move the array to some central spot accessible to both.

[eileenmcnaughton]

@colemanw yeah I guess I dithered a little but then went with 'don't overthink it' - this is a very standard array & not one that would ever change

[colemanw]

For example a public static function getMap() in CRM_Core_Error_Log which returns the array, and also gets called by its constructor for populating $this->map.

[colemanw]

@eileenmcnaughton I updated it, MOP

[eileenmcnaughton]

OK - I was gonna move it to CRM_Core_Error as a more appropriate place to put a static function but this fixes it