Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix updating Entity Ref fields #20125

Merged
merged 1 commit into from
May 6, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 22, 2021

Overview

Fix a couple bugs in SearchKit handling bulk-updates of Entity Ref fields.

Before

  1. Create a custom field type Contact Reference.
  2. Create a search, select one or more rows & choose "Update Contacts" from the Actions menu.
  3. Select the custom field.

Problem 1: Field appears as an integer
Problem 2: Fixing first bug, then selecting "Current User" from the EntityRef widget will fail.

After

Both issues fixed.

@civibot
Copy link

civibot bot commented Apr 22, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

Has a test and the code reads well makes sense to me merging

@seamuslee001 seamuslee001 merged commit 15acadd into civicrm:master May 6, 2021
@seamuslee001 seamuslee001 deleted the searchContactRef branch May 6, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants