dev/core#2509 - Remove duplicate setting of activity subject field and replace a few CRM_Utils_Array::value

[demeritcowboy]

Overview

Similar to #20106 my end goal is to pull out the bit that makes the action links to make it reusable. This smaller simplification will make it easier to see later that all I'll be doing is moving some code into its own function.

Before

Subject is set to the same thing it's already set to on line 2521 near the start of the loop.
Some use of CRM_Utils_Array::value.

After

No double-setting of subject.
CRM_Utils_Array::value replaced.

Technical Details

Comments

You can verify subject is already set by:

1. Create a case.
2. Fill in some subjects on the autopopulated activities to make it obvious what the subject is, otherwise they'll be blank in step 4 which will be disconcerting.
3. Under Admin - CiviCase - CiviCase settings, turn on the option for "Include case activities in general activity views".
4. Visit the client contact's activity tab. The activities from the case you created will show the subject.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

👍 sensible code cleanup

[demeritcowboy]

Thanks!