Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2536 Trim strings from info.xml in extensions #20064

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 14, 2021

Overview

Fixes bug reported in https://lab.civicrm.org/dev/core/-/issues/2536

Before

<requires>
</requires>

and

<requires></requires>

are not equivalent and the former breaks stuff

After

All strings coming in from the xml that do not have children have preceding & trailing white space removed

Technical Details

I don't think we should limit whitespace trimming to this field

Comments

@civibot
Copy link

civibot bot commented Apr 14, 2021

(Standard links)

@civibot civibot bot added the master label Apr 14, 2021
@eileenmcnaughton eileenmcnaughton changed the title Trim strings from info.xml in extensions dev/core#2536 Trim strings from info.xml in extensions Apr 14, 2021
@colemanw
Copy link
Member

This fix makes sense to me.

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Apr 14, 2021
@colemanw colemanw merged commit 6f2a603 into civicrm:master Apr 16, 2021
@colemanw
Copy link
Member

Tested this. Reproduced the bug and confirmed that this fixes it.

@colemanw colemanw deleted the info branch April 16, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants