Add pager to bottom of Manage Contribution Pages #20061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no pager at the bottom of the page, now there is.
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
@larssandergreen Can you add a screenshot? |
|
Looks good |
|
Awesome 🎉 -> is that your first official contribution Lars? 👍 |
|
@KarinG I task you with finding the official party emjoi (I think it might not be @larssandergreen first but I still like party emjois) |
|
Jenkins add to whitelist |
|
@KarinG I think I've updated text here and there before, but more or less,
sure!
…On Wed, Apr 14, 2021 at 4:08 PM Seamus Lee ***@***.***> wrote:
Jenkins add to whitelist
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20061 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCV35C35GNZGPWIN7ZNY23TIYG6PANCNFSM425ZG6XA>
.
|
|
Congrats! 🥳 How did you create the screenshot? I was going to apply your patch to our ectemnia repo for you but you got it done somehow 🙂 |
|
@KarinG It's from a test site, not ours. But we don't really need the patch
right away, not a big deal. I know now that there isn't a pager on the
bottom of that page.
…On Wed, Apr 14, 2021 at 6:45 PM KarinG ***@***.***> wrote:
Congrats! 🥳
How did you create the screenshot? I was going to apply your patch to our
ectemnia repo for you but you got it done somehow 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20061 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCV35GRJV6VPX3QDWOLQOLTIYZLJANCNFSM425ZG6XA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no pager at the bottom of the page, now there is.