Update WP permission page for new string array keys

[colemanw]

Overview

This fixes an undefined index notice for permissions that use the new-style 'label' and 'description' array keys instead of numeric keys.

Before

After

No notice and descriptions are visible:

Technical Details

It seems there is a new syntax supported by the permission system and this WordPress page didn't get the memo.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton am I right in assuming that this new array syntax is what we're moving to and this page needs to support it?

[eileenmcnaughton]

@colemanw yes - although the word 'new' is arguable since I think it has been quite a few years,

This makes sense to me - I'll just give @kcristiano / @christianwach a chance to comment

[christianwach]

I honestly haven't looked at the code that generates that page since I fixed the table layout many moons ago. If this change fixes things, then I'm all for it!

[eileenmcnaughton]

I think the change is trivial enough that that is enough endorsement :-)

[colemanw]

Just an aside, it bugs me when we add a new pattern but don't take the time to update the old ones; they sit around collecting technical debt and, in many cases, get replicated by unsuspecting devs who (correctly) observe them to be the prevalent pattern in our codebase and therefore the correct examples to follow.

[christianwach]

@colemanw Not that I wrote it, but in defence of the code you fixed, it seems to be over six years old, so presumably predates the current pattern. 🤷 😄

[eileenmcnaughton]

@colemanw I hear you & @christianwach I think the comment was directed at whoever fixed if for drupal & not wordpress (which I am totally not going to git blame in case it turns out to be me)