Switch to Call contribution api

[eileenmcnaughton]

Overview

Switches to using the v3 contribution create api in preparation for switching to the v3 Order api

Before

Calls BAO create somewhat directly

After

Calls v3 contribution.create api. 2 params that could not be set are removed (this used to be shared code)

• is_pay_later
• • skipLineItem

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I've read through this diff and looked at the difference between what APIv3 does vs the regular BAO. I don't see any gotchas.
Additional logic in the v3 create function includes:

• Handle legacy param names (doesn't apply)
• Handle financial permissions (only applies if check_permissions is passed in, and it isn't)
• Cleans money (doesn't apply if skipCleanMoney is passed in, and it is)
• Handles update if id is passed in (it isn't)