Add amount as standard property to PaymentPropertyBag

[mattwire]

Overview

amount is already a standard property and has no aliases so technically it doesn't matter if it's in the list of properties or not. But a developer reading the code expects it to be there.

If in the future we needed to add an alias to support some old code (eg. total_amount/gross_amount) you'd need this and then you'd add the aliases to point to it.
I think those properties have gone from core now but if they were still there this would allow transitioning them to amount

Before

amount missing from list of properties.

After

amount in list of properties.

Technical Details

Explained above.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree that was confusing me too.