dev/core#2501 - api uf_group.create overwrites existing fields when updating if they aren't specified

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2501

There are several fields that UFGroup::add() sets to FALSE if you don't specify, so for example updating just the title disables your profile because it sets is_active to 0. I can't think why this would be intentional and looking back through the history there doesn't seem to be a reason I can find.

To reproduce:

1. Create a profile.
2. Set some of the affected fields like the CMS user creation option and the Enable Mapping option.
3. cv api uf_group.create id=15 title=testing, where id is the profile id. Or use api explorer.
4. Back in the UI or in the database look at the fields. The profile is now disabled and those affected fields you set are cleared out.

Before

is_active, the setting for whether to offer cms user creation, mapping, etc, all get turned off.

After

As expected and the way other api calls work.

Technical Details

There are two additional parameters that have different names than their fields, so we need to keep that, but currently they overwrite with null if they're missing. But you might want to blank out a field, so we need to treat missing differently than empty.

Comments

Has test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK I took a look - I agree this is more correct and this is old code so not related to any recentish bug fixes. I think we can otherwise rely on db defaults

[demeritcowboy]

Thanks!