Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrader - Display note about token formatting #19920

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

totten
Copy link
Member

@totten totten commented Mar 27, 2021

Overview

Improve communications about tokens that may generate different output.

This is a follow-up to #19806

Depends: https://lab.civicrm.org/documentation/docs/sysadmin/-/merge_requests/306/

Ping: @eileenmcnaughton

Before

No upgrade notice

After

Screen Shot 2021-03-26 at 5 46 37 PM

@civibot
Copy link

civibot bot commented Mar 27, 2021

(Standard links)

@civibot civibot bot added the master label Mar 27, 2021
@eileenmcnaughton
Copy link
Contributor

@totten I think I would go further and say 'some mail merge tokens for custom fields'

@totten
Copy link
Member Author

totten commented Mar 27, 2021

@eileenmcnaughton I thought it affected both some custom fields and some core fields (eg contact.created_date)?

@eileenmcnaughton
Copy link
Contributor

@totten only in that some fields that didn't work now do

@eileenmcnaughton
Copy link
Contributor

@totten specifically it fixes the 2 issues that we had about received contact.hash not working

@eileenmcnaughton
Copy link
Contributor

I'm going to merge this - the upgrade notes can cover the specific fields - only custom fields are CHANGED. Some additional non-custom-fields are resolved

@eileenmcnaughton eileenmcnaughton merged commit 214a6b8 into civicrm:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants