Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [ipn] Simplification around contributionRecur ID #19903

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Simplification around contributionRecur ID

Before

contributionRecurID set on as a variable, as a key in ids and as a property of the contributionRecur object

After

ids no longer used for it

Technical Details

Note that participantID is always NULL for recurring contributions

Comments

@civibot
Copy link

civibot bot commented Mar 25, 2021

(Standard links)

@civibot civibot bot added the master label Mar 25, 2021
@eileenmcnaughton eileenmcnaughton force-pushed the paypal branch 3 times, most recently from 265b4ca to 5dce3a1 Compare March 25, 2021 07:56
@eileenmcnaughton eileenmcnaughton changed the title [REF] Simplification around contributionRecur ID [REF] [ipn] Simplification around contributionRecur ID Mar 26, 2021
@monishdeb
Copy link
Member

Reviewed the patch, looks good. r-run passed. There is test coverage for the change. Merging now

@monishdeb monishdeb merged commit ca80a30 into civicrm:master Apr 9, 2021
@eileenmcnaughton eileenmcnaughton deleted the paypal branch April 9, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants