Add support for receipt task outside the search process

[eileenmcnaughton]

Overview

Adds support for url-based receipt sending - eg.

https://dmaster.localhost/civicrm/contribute/task?task=receipt&id=40,41

Before

Receipt functionality deeply tied to search process

After

Technical Details

@colemanw this is a first step towards adding more search tasks. I probably need to revisit it a little myself & do more testing but it builds on the cleanup I did a while back towards this

I exposed the action on the contribution tab of a contact - partly because it has been requested in the past but mostly to highlight this change & also the challenges - notably

1. the action is only available for some statuses - this has been implemented using the contexttualLinks function
2. when it opens in a pop-up the pdf won't download. This second one is something of a blocker to exposing it (although we can merge with it not exposed - but I suspect it will also be an issue in search-kit)
   

*** I renamed from Receipt to Send Receipt so the above screenshot is a bit superceded ***

Comments

Remember to do a menu rebuild if you pull locally

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw this is now a fairly direct path towards starting to add contribution actions to search kit results. I haven't figured out what to do about the pdf not working in a modal yet though.

[colemanw]

Ah, the old pdf-download-from-a-dialogue issue. I remember it well.
The solution is to disable ajax submit in the form, like this:

civicrm-core/CRM/Event/Form/Task/Badge.php

Lines 69 to 73 in bc77d7c

	public function buildQuickForm() {
	CRM_Utils_System::setTitle(ts('Make Name Badges'));
	// Ajax submit would interfere with file download
	$this->preventAjaxSubmit();

(note that setting only affects dialogs)

[eileenmcnaughton]

@colemanw that works.

I think this is mergeable now although I think the contract around describing the links (getContextualLinks) could change and we haven't actually had the discussion about exposing the ability to send a receipt from the contribution tab (I tend to see it as a missing feature but I can't assume everyone else would)

I'm open to leaving this until after the rc is cut to give us more flexibility

[colemanw]

I'm open to leaving this until after the rc is cut to give us more flexibility

Sounds good

[colemanw]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass: Adds a requested feature
  • (r-doc) Pass
  • (r-run) Pass
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass*
  • (r-maint) Pass
  • (r-test) Pass

* I note that the class structure for this standalone Contribution is different than the standalone Contact actions. They each implemented their own menu route while this uses a generic route with a ?task=receipt argument. Not sure which is better but it's not a blocker to merge.

[MegaphoneJon]

While not directly related to this PR, I imagine that folks reading this later may be interested in Fast Action Links plus Fast Action PDF. I wrote Fast Action PDF to allow generating PDF thank-you letters from the contributions tab.

The difference between this approach and Fast Action PDF is in the number of clicks. If you always use the same 1 or 2 templates, it's valuable to create a PDF in a single click. This PR gives more flexibility at creation time, but takes more clicks.

[eileenmcnaughton]

@MegaphoneJon cool yes - that does sound like it would be much appreciated by some users