SearchKit - Fix removing all related fields from SELECT when removing a JOIN

[colemanw]

Overview

Fixes a small bug in SearchKit where not all columns get cleaned up when deleting a JOIN.

Before

1. Search for Contacts
2. Add GROUP BY id
3. Add a join to Activity
4. Activity subject will appear as a column
5. Choose an aggregate function for the subject column (or click search and it will add one automatically)
6. Delete the join to Activity

Result: the column is still there.

After

Repeat steps above.

Result: the column gets auto-deleted.

Technical Details

This bug wasn't causing a db error because the API silently ignores any unknown fields in the SELECT clause. So it was just annoying and confusing (even to Eileen).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

retest this please

[eileenmcnaughton]

OK - I was able to replicate this and it is fixed on the demo site.

One thing I found confusing with demo data is that that the default activity join is on activity assignee & this it mostly unpopulated on the demo data. I suspect that even on real world data 'target' would be a better default

[colemanw]

@eileenmcnaughton thanks. I think the answer to that would be adjusting the weights in the "Activity Contacts" option group. SearchKit just defaults to the first option in a group.

[eileenmcnaughton]

Ok - that's easy technically - I will create a gitlab & link in dev digest