Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Add in unit test to prove that domain tokens are able to be inc… #19702

Merged

Conversation

seamuslee001
Copy link
Contributor

…ldued in peition emails

Overview

This adds in a unit test to cover off the fact that domain tokens can be use in Petition thank you emails

Before

No Test

After

Test

ping @eileenmcnaughton @JoeMurray

@civibot
Copy link

civibot bot commented Mar 1, 2021

(Standard links)

@civibot civibot bot added the master label Mar 1, 2021
@eileenmcnaughton
Copy link
Contributor

thanks @seamuslee001 - the red x is jenkins making style commentary

Will we follow up by switching petitions to use token compat in some way? (Where are the lines that do the replacement in this flow?)

@seamuslee001 seamuslee001 force-pushed the domain_petition_emails branch from 22bc938 to ce9f260 Compare March 1, 2021 20:21
@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton it was more so I didn't think you could use domain tokens in these workflow templates and started by writing a unit test for it and seem to work so figured more tests the better. For petition tokens it seems to rely on https://github.com/civicrm/civicrm-core/blob/master/CRM/Campaign/BAO/Petition.php#L579 and https://github.com/civicrm/civicrm-core/blob/master/CRM/Campaign/BAO/Petition.php#L644

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 so it's already swapped out in sendmail

@eileenmcnaughton eileenmcnaughton merged commit 4283a02 into civicrm:master Mar 2, 2021
@eileenmcnaughton eileenmcnaughton deleted the domain_petition_emails branch March 2, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants