APIv4 - Rename 'controlField' property to 'control_field'

[colemanw]

Overview

By convention, all keys returned from the api should be lowercase.

This renames a key that was not. It was only used in 2 places.

Before

\Civi\Api4\Address::getFields() returns 'input_type' => ['controlField' => ...

After

\Civi\Api4\Address::getFields() returns 'input_type' => ['control_field' => ...

Comments

In general, it's not good to make "breaking changes" to our API, but this is a very obscure sub-property of only one entity that is only used by Afform so far, and APIv4 is still relatively new. IMO this is reasonably safe, and better now than later.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton this is per our discussion on #19629

[eileenmcnaughton]

OK - I did a universe grep & the only other related place was the old afform module - which should be gone by this version anyway now.

Test fails are leap year related & affect a bunch of PRs today