SearchKit - Fix clearing selection behavior #19686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the bug documented in https://lab.civicrm.org/dev/core/-/issues/2419
Before
After selecting all rows and updating search criteria, the rows would all still appear to be selected but the Actions menu would be disabled.
After
After selecting all (or any) rows and updating search criteria, the selection will be cleared (which was the original intent).
Technical Details
The variables
allRowsSelected
andselectedRows
were sometimes getting out-of-sync.This adds a function to help ensure they both get updated at the same time when the selection needs to be cleared.