dev/core#1400 - Put dashlets back to only showing open cases by default

[demeritcowboy]

Overview

This is pending what happens with #19666.

Before

Before 19666, case dashlets only show open cases when first displayed.

After

After 19666, it causes them to start showing closed cases too. This puts it back to open cases.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Removed pending from title.

[eileenmcnaughton]

I've given this merge-ready as I think it's arguably a reviewer's-commit but ideally @kainuk would weigh in

[kainuk]

I will look into it tomorrow.

[eileenmcnaughton]

thanks @kainuk - I think there is one other one too

[demeritcowboy]

The other one is just a test demonstrating #19666 . That one should be mergeable now.

[eileenmcnaughton]

@kainuk I'm going to merge this now because it does need to be in the same release as your PR and I don't want it to get missed/forgotten - but could you please still test it? If you find it easier it will be in the rc by the end of the week and you can test the tarball

[kainuk]

I just tested the MyCases Dashlet. In my 5.12 instance (the version from before the regression) the dashlets show no closed cases.
Without #19666 and this patch the following is shown (in the data there is one closed case, so that's what we expect).

After #19666 and this patch it looks like this.
.

Now in the case status field is shown what statuses are selected (the selection is the same). I think this is an improvement because it gives the user better feedback.

[kainuk]

The same for the All Case Dashlet. In the manual test, the patch is found working as intended. A good idea to merge it.

[eileenmcnaughton]

Thanks for following up @kainuk

[demeritcowboy]

Great! Thanks @kainuk for testing.