Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC/Unit Test] Fix passing test that should pass but also should fail #19607

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

It should pass because the test itself seems good. But it should fail because it's comparing something that in php < 7.4 silently casts to 0 and so happens to assertEqual to 0. In php 7.4 it correctly points out that it's trying to access an array key on a variable of type int.

CRM_Case_BAO_CaseTest::testInactiveCaseRole
Notice: Trying to access array offset on value of type int ... line 107

@civibot
Copy link

civibot bot commented Feb 15, 2021

(Standard links)

@civibot civibot bot added the master label Feb 15, 2021
@eileenmcnaughton eileenmcnaughton merged commit af58410 into civicrm:master Feb 16, 2021
@demeritcowboy demeritcowboy deleted the unit-assert-cases branch February 16, 2021 16:37
@demeritcowboy
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants