[REF] simplify parameter, use preferred strict

[eileenmcnaughton]

Overview

Minor cleanup

Before

$b = $x;
$c = $x['values'];

After

$c = $b['values'];

Technical Details

In addition strict comparison is used for the in_array function - better coding practice but effectively the same here

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton The description doesn't match the code here!

[eileenmcnaughton]

@mattwire - does it need a comma? - it simplifies the described parameter (although I have used shorter variables to illustrate the simplified pattern) & uses the preferred strict mode for comparisons

[mattwire]

Actually I was thinking you were trying to update this bit of code https://github.com/civicrm/civicrm-core/blob/master/Civi/Token/TokenRow.php#L149 :-)

[eileenmcnaughton]

@mattwire nope - the description just covers these changes

https://github.com/civicrm/civicrm-core/pull/19597/files#diff-c250584f6056eea3cae87f5cbd02b21dacc6bd31b4b72b697d9831d1f43c2396R99-R103

But I shortened it in the descriptor to be the concept not the exact same thing you would get if you read the diff

[colemanw]

Man that in_array() bug is a real pain. I wish the default was strict, but it's good you're adding it now.

[eileenmcnaughton]

Yeah - it's only a theoretical issue in most cases - but it's best coding practice to use strict