php 7.4 - E_NOTICE on membership dashboard

[demeritcowboy]

Overview

1. Visit membership dashboard
2. E_NOTICE: Trying to access array offset on value of type null

Before

notice

After

no notice

Technical Details

php 7.4 seems a bit stricter about self:: arrays when you access a nonexistent member.

In php 7.3 trying to access self::$foo['bar'] when bar doesn't exist doesn't seem to give a notice.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy i'm thinking that there maybe other places that need patching as well see https://github.com/civicrm/civicrm-core/search?q=_links

[demeritcowboy]

Good thought but just browsing those none of them access member elements, just the main var which doesn't give an error. But I'm sure yes there some non-link variables elsewhere that do something like this.

[eileenmcnaughton]

Merging this as above conversation is non-blocking