Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Repeattransaction] Stop setting contribution->id #19538

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Stop setting contribution->id

Before

$contribution object used to pass around contribution id

After

$contributionResult object used to pass around contribution id

Technical Details

This is not needed as we can otherwise get it from the contributionResult directly

The $contribution object is more or less obsolete in this function & ideally we want to remove it

Comments

This is not needed as we can otherwise get it from the contributionResult directly
@civibot
Copy link

civibot bot commented Feb 5, 2021

(Standard links)

@civibot civibot bot added the master label Feb 5, 2021
@eileenmcnaughton eileenmcnaughton changed the title [REF] Stop setting contribution->id [REF] [Repeattransaction] Stop setting contribution->id Feb 5, 2021
@mattwire mattwire merged commit 338ca6e into civicrm:master Feb 5, 2021
@eileenmcnaughton eileenmcnaughton deleted the repeat branch February 5, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants