[REF] Convert previously shared function to non-static, remove unrelated code #19258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
…ted code There is no facility for creating on_behalf on back office membership forms so this code, copied from the shared function, does not relate. The activity IS created by Contribution.create - the extra code was just to hack it around to doing on_behalf Likewise, the back office membership form does not collect data on contribution custom fields or notes so removing these also makes sense here.
eileenmcnaughton
force-pushed
the
recur_test
branch
from
3759a39 to
2a32035
Compare
| @@ -1920,44 +1919,6 @@ public static function processFormContribution( | |||
| //CRM-13981, processing honor contact into soft-credit contribution | |||
| CRM_Contribute_BAO_ContributionSoft::processSoftContribution($params, $contribution); | |||
|
|
|||
| if ($contribution) { | |||
There was a problem hiding this comment.
So just to articulate here, the reason for this is because no Contribution Custom fields are exposed on the Back office Membership form right?
There was a problem hiding this comment.
@seamuslee001 exactly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Convert previously shared function to non-static, remove unrelated code
Before
Previously shared code, copied back to clean up, contains things unrelated / inaccessible from the membership back office form & is static
After
Technical Details
There is no facility for creating on_behalf on back office membership forms
so this code, copied from the shared function, does not relate.
The activity IS created by Contribution.create - the extra code was
just to hack it around to doing on_behalf
Likewise, the back office membership form does not collect
data on contribution custom fields or notes so removing these
also makes sense here.
Comments