dev/core#2270 - Editing a smartgroup created through the search builder renders the new block by force

[VangelisP]

Overview

This is a PR of issue https://lab.civicrm.org/dev/core/-/issues/2270 where the new block (select record type / operator) is render on both cases: on a new search builder form and on existing search builder forms (when editing the smartgroup)

Before

The new record type/operator line is now appearing on either an existing smartgroup done via the searchbuilder or on a new searchbuilder form.

After

The new record type + operator line should appear only on the new searchbuilder form

Technical Details

Assuming that I am not skipping anything, there should be a check happening here .
For example, right now it's :

for example this:

    // Initialize new form
    if (!$this->_blockCount) {
      $this->_blockCount = 4;
      $this->set('newBlock', 1);
    }

should be something like this:

    // Initialize new form
    if (!$this->_blockCount) {
      $this->_blockCount = 4;
      if (!$this->_ssID) {
        $this->set('newBlock', 1);
      }
    }

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This needs an r-run but as long as it passes that is good to merge IHMO

[demeritcowboy]

r-run: looks good

[seamuslee001]

merging as per the review from Eileen and Dave