Remove unused tpl assigns #19226
Merged
Remove unused tpl assigns #19226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These really look like they were copied over from participant forms - they are not used in the membership tpl receipts
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These really look like they were copied over from participant forms -
they are not used in the membership tpl receipts
Overview
Remove unused tpl assigns
Before
ContributeMode and isAmountZero are assigned to the tpl but these are used in participant message templates, not membership ones.
After
poof
Technical Details
This looks to me like code that came from the Participant code rather than was ever relevant to membership tpls, of else it is long gone from them
Comments