dev/core#2246 Fix failure to filter exports #19176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes regression caused by us more consistently setting componentTable. The short version here is that the presence of a componentClause should take precedences over the inner join intended as a blunt, and maybe unnecessary, measure to limit the export to the entity in question
|
(Standard links)
|
|
Jenkins retest this please |
|
test this please |
|
Jenkins retest this please |
|
jenkins you are a grumpy bum |
|
Jenkins retest this please |
|
I replicated this locally and confirmed that this fixes the problem MOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a failure to apply limits to member exports per https://lab.civicrm.org/dev/core/-/issues/2246
Before
All memberships exported when selecting specific ones
After
Only the specific ones are exported
Technical Details
This fixes regression caused by us more consistently setting componentTable. Unfortunately it turned out componentTable is a bit of a magic parameter in this code that triggers the first part of an if clause - leading us to miss the else bit,
The short version here is that the presence of a componentClause should take precedences
over the inner join intended as a blunt, and maybe unnecessary, measure to
limit the export to the entity in question
Comments